This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Dev refactor savelogs#126
Merged
oracle58 merged 34 commits intoHelixNetwork:devfrom Sep 5, 2019
Merged
Conversation
Pull in of changes timestamp validation, gitignore, writing to snapshot fixed, snapshot time, timestamp in ms, spend addresses on loadup false
Sync with upstream zmq fix by of
Get changes from upstream
Sync with upstream
Upstream sync
take changes from origin
Merge upstream dev into fork dev
Pull in upstream changes
Sync with upstream
Sync with upstream dev
Pull in upstream dev changes
Contributor
Codecov Report
@@ Coverage Diff @@
## dev #126 +/- ##
============================================
+ Coverage 46.35% 46.36% +<.01%
- Complexity 1225 1227 +2
============================================
Files 160 160
Lines 7623 7626 +3
Branches 934 934
============================================
+ Hits 3534 3536 +2
- Misses 3715 3718 +3
+ Partials 374 372 -2
Continue to review full report at Codecov.
|
oracle58
approved these changes
Sep 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the refactor of the saveLogs method suggested in Issue #124.